Update avalanche ledger go package #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Oct 16, 2024
marun
reviewed
Oct 16, 2024
| @@ -11,7 +11,7 @@ require ( | |||
| github.com/NYTimes/gziphandler v1.1.1 | |||
| github.com/antithesishq/antithesis-sdk-go v0.3.8 | |||
| github.com/ava-labs/coreth v0.13.8 | |||
| github.com/ava-labs/ledger-avalanche/go v0.0.0-20240610153809-9c955cc90a95 | |||
| github.com/ava-labs/ledger-avalanche/go v0.0.0-20241009183145-e6f90a8a1a60 | |||
There was a problem hiding this comment.
Are there release versions for ledger-avalanche?
There was a problem hiding this comment.
I don't think so for the go wrapper
| google.golang.org/genproto/googleapis/rpc v0.0.0-20240123012728-ef4313101c80 | ||
| google.golang.org/grpc v1.62.0 | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20240827150818-7e3bb234dfed | ||
| google.golang.org/grpc v1.66.0 |
There was a problem hiding this comment.
Updating the gprc version is bold... Shouldn't be an issue... But would be good to QA this prior to release though.
StephenButtolph
approved these changes
Oct 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Update ledger avalanche go package that solves issue described in ava-labs/ledger-avalanche#326
How this works
NA
How this was tested
NA