Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tmpnet] Add --start-network to support hypersdk MODE=run #3465

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Oct 11, 2024

Why this should be merged

Hypersdk tooling has long supported supplying MODE=run to its run.sh script to start a network and leave it running without executing any tests. When hypersdk switched to tmpnet, the run script was updated to specify --reuse-network and run a trivial test, but the use of --reuse-network risks confusion if a user expects the resulting network to reflect the latest binary state. Adding explicit support for always starting a new network avoids this risk.

How this works

  • Add new flag --start-network to the tmpnet env flags
  • If the flag is provided, start a new network, avoid stopping it on cleanup, and exit before running any tests

How this was tested

CI for regression, locally to check that a new network was started and stayed running

@marun marun added the testing This primarily focuses on testing label Oct 11, 2024
@marun marun self-assigned this Oct 11, 2024
@marun marun force-pushed the tmpnet-add-start-network branch from c70512a to 80f294a Compare October 11, 2024 23:45
Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-kim joshua-kim added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 2c84afe Oct 18, 2024
23 checks passed
@joshua-kim joshua-kim deleted the tmpnet-add-start-network branch October 18, 2024 19:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants