[tmpnet] Add --start-network to support hypersdk MODE=run #3465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Hypersdk tooling has long supported supplying
MODE=run
to itsrun.sh
script to start a network and leave it running without executing any tests. When hypersdk switched to tmpnet, the run script was updated to specify--reuse-network
and run a trivial test, but the use of--reuse-network
risks confusion if a user expects the resulting network to reflect the latest binary state. Adding explicit support for always starting a new network avoids this risk.How this works
--start-network
to the tmpnet env flagsHow this was tested
CI for regression, locally to check that a new network was started and stayed running