Update SoV struct to align with latest ACP-77 spec #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Oct 24, 2024
|
|
||
| // validateConstants returns true if the constants of this validator have not | ||
| // been modified. | ||
| func (v SubnetOnlyValidator) validateConstants(o SubnetOnlyValidator) bool { |
There was a problem hiding this comment.
(No action required) Maybe rename to something more descriptive/a question answered by a boolean (e.g. constantsAreUnmodified)?
Also, is this method intended going to be used by non-test code in subsequent PRs?
There was a problem hiding this comment.
yeah this helper is used is later PRs
| } | ||
| return vdr, err | ||
| return vdr, nil |
| } | ||
| } | ||
|
|
||
| func TestSubnetOnlyValidator_validateConstants(t *testing.T) { |
There was a problem hiding this comment.
(No action required) As much as I like test tables, maybe it would be easier to maintain a procedural approach that modified the parameter to validateConstants field-by-field?
ceyonur
approved these changes
Oct 24, 2024
yacovm
pushed a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
yacovm
pushed a commit
to yacovm/avalanchego
that referenced
this pull request
Oct 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3388.
How this works
RemainingBalanceOwnerDeactivationOwnerEndAccumulatedFee == 0implies inactiveCompareontoSubnetOnlyValidatorSubnetOnlyValidators by value rather than reference so that modifying them can be done without changing the original valueHow this was tested