Add ValidatorWeightDiff Add and Sub helpers
#3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
approved these changes
Nov 1, 2024
samliok
approved these changes
Nov 1, 2024
3 tasks
marun
approved these changes
Nov 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently
Add(true/false, amount)is pretty clunky to use. It was implemented this way to avoid duplicate code in the implementation, but adds needless complexity during the usage.How this works
This PR un-exports the current
Add(bool, uint64)function and replaces it withAdd(uint64)andSub(uint64).How this was tested
Updated existing tests.
Need to be documented in RELEASES.md?
No user facing changes.