Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add script to configure metrics and log collection from a local node #3517

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Nov 4, 2024

Why this should be merged

Collecting logs and metrics shouldn't always require running on monitored infrastructure when collection to the CI monitoring stack from a local node is possible.

How this works

Adds promtail and prometheus configuration for a local node to the path expected by the instances started by the scripts/run_prometheus.sh and scripts/run_promtail.sh scripts.

How this was tested

Manually

Need to be documented in RELEASES.md?

N/A

@marun marun self-assigned this Nov 4, 2024
Copy link
Contributor

@meaghanfitzgerald meaghanfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for writing this script!

Copy link
Contributor

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this script intended to be invoked from?

@marun
Copy link
Contributor Author

marun commented Nov 5, 2024

where is this script intended to be invoked from?

There is no requirement to invoke it from a specific location, the paths it uses are determined by environment vars (e.g. $HOME) rather than dependent on the working directory.

Edit: Hmm, or did you mean 'by what/whom'?

@marun marun added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 3d81d5b Nov 5, 2024
23 checks passed
@marun marun deleted the local-monitoring-config branch November 5, 2024 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants