Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ci] Always use the specified go version #3616

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

marun
Copy link
Contributor

@marun marun commented Dec 21, 2024

By virtue of supplying check-latest to the setup-go action, CI jobs were using the latest release of the specified golang version rather than the exact version. Better to always use the exact version to ensure that the version used for testing matches that used for development.

As per this CI log:

...
Setup go version spec ~1.22.8
Attempting to resolve the latest version from the manifest...
matching ~1.22.8...
Resolved as '1.22.10'
...

@marun marun added the ci This focuses on changes to the CI process label Dec 21, 2024
@marun marun self-assigned this Dec 21, 2024
By virtue of supplying `check-latest` to the setup-go action, CI jobs
were using the latest release of the specified golang version rather
than the exact version. Better to always use the exact version to
ensure that the version used for testing matches that used for
development.
@marun marun force-pushed the ci-exact-golang-version branch from 1d3dda2 to 5af3b94 Compare December 21, 2024 07:54
@marun marun added this pull request to the merge queue Dec 26, 2024
Merged via the queue into master with commit 9c69c9f Dec 26, 2024
23 checks passed
@marun marun deleted the ci-exact-golang-version branch December 26, 2024 20:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants