-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Index API and AvalancheGo Configs Docs Fix #3632
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5c111c5
index api
meaghanfitzgerald 866a2bd
http flags moved doc partially alphabetized
meaghanfitzgerald 3521651
flag sections alphabetized, excluding advanced
meaghanfitzgerald 296e043
fix links
meaghanfitzgerald 7922bba
format json
meaghanfitzgerald a786922
Merge branch 'master' into api-docs-edits
meaghanfitzgerald b4e16bd
add tab in json
meaghanfitzgerald 90b140e
go code block
meaghanfitzgerald 37d065d
move genesis docs to genesis package and add note on initial staker h…
aaronbuchwald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't valid json either (and the github visual of this block does not like that it is marked as json)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a valid json because of the comments? either way this doc is completely non functional. Would rather please .md standards than GH because this doc is hosted on our dev docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe have it as
text
? 🤔 Maybe json gets rendered as extended json depending on the rendering engine...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text removes all color-coding which makes it a bit harder to read.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I readded the tab and set the codeblock back to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/DavidAnson/markdownlint/blob/main/doc/md010.md