Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TestSnowContext util #430

Merged
merged 17 commits into from
Dec 22, 2023
Merged

Add TestSnowContext util #430

merged 17 commits into from
Dec 22, 2023

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Dec 19, 2023

Why this should be merged

We're removing snow.DefaultContextTest in AvalancheGo (ava-labs/avalanchego#2518). In-lining this function in coreth to unblock that PR

Don't have any particular attachment to putting it in utils, feel free to move wherever you think makes sense!

How this works

add func and use it

How this was tested

CI

@dhrubabasu dhrubabasu added the testing Anything testing-related label Dec 19, 2023
@dhrubabasu dhrubabasu self-assigned this Dec 19, 2023
@dhrubabasu dhrubabasu marked this pull request as draft December 19, 2023 16:35
joshua-kim and others added 6 commits December 19, 2023 18:12
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
@dhrubabasu dhrubabasu changed the base branch from master to gossip-parser December 21, 2023 21:13
Base automatically changed from gossip-parser to master December 21, 2023 23:31
@dhrubabasu dhrubabasu changed the title Use snowtest pkg Add TestSnowContext util Dec 22, 2023
@dhrubabasu dhrubabasu marked this pull request as ready for review December 22, 2023 00:49
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need a similar PR to subnet-evm as well.

@dhrubabasu dhrubabasu requested a review from ceyonur December 22, 2023 17:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing Anything testing-related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants