Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Integrate stake weighted gossip selection #511

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Integrate stake weighted gossip selection #511

merged 5 commits into from
Mar 13, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Mar 8, 2024 •
edited
Loading

@StephenButtolph StephenButtolph marked this pull request as ready for review March 11, 2024 22:52
@StephenButtolph StephenButtolph self-assigned this Mar 11, 2024
darioush
darioush approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we validate this option so that it is not > 1 ?

@StephenButtolph
Copy link
Contributor Author

should we validate this option so that it is not > 1 ?

It isn't required (the lib will handle it gracefully). But the value would be unexpected

@darioush darioush enabled auto-merge (squash) March 13, 2024 00:18
@darioush darioush merged commit 16cf255 into master Mar 13, 2024
8 checks passed
@darioush darioush deleted the validator-rankings branch March 13, 2024 00:49
oxbee pushed a commit to taurusgroup/coreth that referenced this pull request Nov 6, 2024
@StephenButtolph @oxbee
Integrate stake weighted gossip selection (ava-labs#511)
92e04d1 
* Integrate stake weighted gossip selection

* nit

* merged

* add validity check
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@darioush darioush darioush approved these changes

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

Assignees

@StephenButtolph StephenButtolph

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @darioush @dhrubabasu