Beacon root check #529
Merged
Beacon root check #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Apr 25, 2024
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* add parent beacon root checks * add beacon root tests * revert code change * remove comment
darioush
added a commit
that referenced
this pull request
Apr 27, 2024
* format as subnet-evm * sync subnet-evm up to c77ba56 * reformat as coreth * fix tests * Tx indexing fix (#1131) * fix unindexor in state sync * fix lint * fix flaky test * Update core/blockchain_test.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * fix reviews * readd delay for index init * Update core/rawdb/accessors_state_sync.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * tx indexer fix: avoids using sleep in test (#1151) * avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> * fix require in test * snapshot: fix race in abort/generate (#1155) * skip pkg cache and update version (#1158) * skip pkg cache and update version * remove goconst linter * ignore tests for goconst * use less blocks to gen * add matrix and race to UTs (#530) * add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test * fix test * return if sub nil * Beacon root check (#529) * add parent beacon root checks * add beacon root tests * revert code change * remove comment * nits for sync-subnet-evm (#539) --------- Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* format as subnet-evm * sync subnet-evm up to c77ba56 * reformat as coreth * fix tests * Tx indexing fix (#1131) * fix unindexor in state sync * fix lint * fix flaky test * Update core/blockchain_test.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * fix reviews * readd delay for index init * Update core/rawdb/accessors_state_sync.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * tx indexer fix: avoids using sleep in test (#1151) * avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> * fix require in test * snapshot: fix race in abort/generate (#1155) * skip pkg cache and update version (#1158) * skip pkg cache and update version * remove goconst linter * ignore tests for goconst * use less blocks to gen * add matrix and race to UTs (ava-labs#530) * add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test * fix test * return if sub nil * Beacon root check (ava-labs#529) * add parent beacon root checks * add beacon root tests * revert code change * remove comment * nits for sync-subnet-evm (ava-labs#539) --------- Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds parent beacon root check for cancun + non-cancun cases
How this works
In non-cancun parent beacon root must be nil
In cancun it should be an empty hash
How this was tested
Added UT