eupgrade: lowering the base fee #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
darioush
commented
Jul 18, 2024
| @@ -30,6 +30,7 @@ const ( | |||
| ApricotPhase4BaseFeeChangeDenominator uint64 = 12 | |||
| ApricotPhase5TargetGas uint64 = 15_000_000 | |||
| ApricotPhase5BaseFeeChangeDenominator uint64 = 36 | |||
| EUpgradeMinBaseFee int64 = GWei | |||
There was a problem hiding this comment.
nit: convert all min/max base fee values to use GWei?
| @@ -540,7 +540,7 @@ type ChainConfig struct { | |||
| // Note: EIP-4895 is excluded since withdrawals are not relevant to the Avalanche C-Chain or Subnets running the EVM. | |||
| DurangoBlockTimestamp *uint64 `json:"durangoBlockTimestamp,omitempty"` | |||
| // EUpgrade on the Avalanche network. (nil = no fork, 0 = already activated) | |||
| // It activates Cancun (TODO) and modifies the min base fee (TODO). | |||
| // It activates Cancun and reduces the min base fee. | |||
There was a problem hiding this comment.
nit: follow comment style from above ie. EUpgrade activates...
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* eupgrade: base definitions * updates * nit: consistently use EUpgrade for replace later * update test configs * refactor json genesis specs in vm_test.go * set min base fee at EUpgrade * nit: comment * Update params/config.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * add ut * nit: comment --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The EUpgrade is considering lowering the base fee: #602
How this works
How this was tested
CI