fix TestMempoolEthTxsAppGossipHandling #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Aug 9, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
…va-labs/coreth into fix-TestMempoolEthTxsAppGossipHandling
ceyonur
approved these changes
Aug 9, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* fix TestMempoolEthTxsAppGossipHandling * Update plugin/evm/gossiper_eth_gossiping_test.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * fix atomic test too --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the test.
We modified the code behavior to not gossip p2p txs over push gossip but since the ut was marked flaky it was not noticed & updated.