Refactor params config #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Aug 13, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* get upgrade configs from context * fix chainIDs * fix avago version * commment out override * Remove comment out code * use network ID rather than chain ID * refactor params config * update avago * rename * fix runtime networks * Update params/network_upgrades.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Refactors the param/config file to reduce the upstream diff and moves extra functions/variables to relative files.
How this works
Creates a new struct
NetworkUpgradesthat wraps the Avalanche Network Upgrades which is then embedded into theChainConfig. This is a refactor and nothing (at least in theory) should change.How this was tested
Existing tests should cover this.