Teleporter test cases - part 1 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball,
bernard-avalabs and
feuGeneA
as code owners
gwen917
reviewed
Nov 7, 2023
| // | ||
|
|
||
| optsA := utils.CreateTransactorOpts(ctx, subnetAInfo, fundedAddress, fundedKey) | ||
| _, tx, subnetAExampleMessenger, err := examplecrosschainmessenger.DeployExampleCrossChainMessenger(optsA, subnetAInfo.ChainRPCClient, subnetAInfo.TeleporterRegistryAddress) |
There was a problem hiding this comment.
Do we want to move contract deployment to utils? so that it can be re-used.
There was a problem hiding this comment.
Good call. We use this contract frequently to test Teleporter edge cases, so it makes sense to have this a widely available utility. I've added this in.
| fundedKey, | ||
| teleporterContractAddress, | ||
| ) | ||
| utils.SendTransactionAndWaitForAcceptance(ctx, subnetBInfo.ChainWSClient, subnetBInfo.ChainRPCClient, signedTx, true) |
There was a problem hiding this comment.
do we want to use abi binding to call RetryMessageExecution directly?
There was a problem hiding this comment.
Good call, fixed now
gwen917
approved these changes
Nov 7, 2023
minghinmatthewlam
pushed a commit
that referenced
this pull request
Oct 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements the following test cases from #94
Also implements the ExampleCrossChainMessenger integration test in Ginkgo. This is already implemented in bash, but all bash tests will eventually be ported to Ginkgo. This partially addresses #27
Ports a handful of E2E utility changes from #40
How this works
See above
How this was tested
New E2E test cases
How is this documented
N/A