add api node to network if it is a validator

[felipemadero]

Why this should be merged

When the so called API node is inside the validator set for the source blockchain, it is not added itself as it is not a peer of himself (only peers to API node are added). In situations were that validator is needed to fully sign a msg, teleporter can't proceed beyond relayer step.

How this works

The API node adds himself is belonging to the validators set

How this was tested

It was tested on teleporter deploys on fuji for subnets of only one validator.

How is this documented

[cam-schultz]

Thanks for bringing this up, we should definitely account for this case.

However, this is incompatible with the public API, as info.GetNodeID and info.GetNodeIP are disabled. Instead, I think we should move your changes below the existing peer connection loop like so:

get the list of peers
foreach peer {
    attempt to connect to peer
}

// new code starts here
if len(connectedPeers) < len(nodeIDs) {
    attempt manually connect to API node
}

If the relayer is configured to use the public API, then the peer connection loop should succeed, and we will not call info.GetNodeID / info.GetNodeIP. Otherwise, if the info API node is also a validator, it's required for those two methods to be enabled.

Can you please make this change, as well as document the updated API requirements in the README? Thanks.

[felipemadero]

Thanks for bringing this up, we should definitely account for this case.

However, this is incompatible with the public API, as info.GetNodeID and info.GetNodeIP are disabled. Instead, I think we should move your changes below the existing peer connection loop like so:

get the list of peers
foreach peer {
    attempt to connect to peer
}

// new code starts here
if len(connectedPeers) < len(nodeIDs) {
    attempt manually connect to API node
}

If the relayer is configured to use the public API, then the peer connection loop should succeed, and we will not call info.GetNodeID / info.GetNodeIP. Otherwise, if the info API node is also a validator, it's required for those two methods to be enabled.

Can you please make this change, as well as document the updated API requirements in the README? Thanks.

done

[cam-schultz]

LGTM