Portable BLST #25
Merged
Portable BLST #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
scripts/test.sh
Outdated
| set -o pipefail | ||
|
|
||
| # Directory above this script | ||
| RELAYER_PATH=$( cd "$( dirname "${BASH_SOURCE[0]}" )"; cd .. && pwd ) |
There was a problem hiding this comment.
nit: can you make this into two lines like above
There was a problem hiding this comment.
Lets also do the same in constants.sh
| # | ||
| # We use "export" here instead of just setting a bash variable because we need | ||
| # to pass this flag to all child processes spawned by the shell. | ||
| export CGO_CFLAGS="-O -D__BLST_PORTABLE__" |
There was a problem hiding this comment.
do we need this for teleporter as well?
There was a problem hiding this comment.
The teleporter repo itself doesn't have any Go applications that use BLST. Those should just be avalanchego, subnet-evm, and the relayer.
There was a problem hiding this comment.
LGTM, just the one nit from @minghinmatthewlam would be good to keep uniform.
cam-schultz
dismissed stale reviews from gwen917 and minghinmatthewlam
via
ccbc8de
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam and
gwen917
michaelkaplan13
approved these changes
Sep 5, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes cross-platform application and unit test execution by adding portable BLST flags. Otherwise, execution fails with
SIGILLHow this works
constants.shtest.shthat sourcesconstants.shHow this was tested
CI, Teleporter integration tests