Add a Go linter to CI #28
Conversation
gwen917
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
| # Copyright (C) 2023, Ava Labs, Inc. All rights reserved. | ||
| # See the file LICENSE for licensing terms. | ||
|
|
||
| set -o errexit |
There was a problem hiding this comment.
can you add a comment about what these do
| on: | ||
| push: | ||
| branches: | ||
| - '*' |
There was a problem hiding this comment.
I think we should run this in the same way as most of our other checks - on all PRs and also pushes to main.
There was a problem hiding this comment.
Does this not check all PRs and push to main? The test.yml did the same.
There was a problem hiding this comment.
It does, but it also checks every push to any branch even if it is not contained in a PR. The general idea is to limit the load on the CI servers by only checking a PRs, because branches probably don't need checks before that.
There was a problem hiding this comment.
Discussed during the standup yesterday. The lint is light weighted. It should should be fine running for every push.
Why this should be merged
How this works
How this was tested