-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Integrate warp non compatible changes #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes LGTM, but do we need to encode the signed message as an array now that the warp predicate can contain multiple messages?
I would have also expected there to be a messageIndex
parameter added somewhere since it's now a parameter to the getVerifiedWarpMessage
precompile call. I'm not sure if we're planning on allowing that to be a parameter in receiveCrossChainMessage
in Teleporter or not, though seems like it would likely make sense to.
The slices are handled by the Agreed |
Oh nice! I didn't realize that about how the predicates are encoded within the And sounds good about the index. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agree with Michael's comment to have Index
as the first parameter to receiveCrossChainMessage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a22f282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Why this should be merged
Warp has non compatible changes recently added in
v0.5.6
that changes how Teleporter integrates with the precompile. We need to update relayer with any corresponding changes and update subnet-evm version. Fixes #24How this works
Updates subnet-evm version dependency, uses
predicateutils
for predicate txHow this was tested
Building local docker image, and running e2e test with corresponding teleporter changes ava-labs/icm-contracts#29