Fixup release flow #487
Merged
Fixup release flow #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this, running the binaries (with a valid config file) in the images was resulting in: ``` panic: failed to issue request: Post "https://api.avax-test.network/ext/info": tls: failed to verify certificate: x509: certificate signed by unknown authority goroutine 1 [running]: main.main() /home/gene/dev/awm-relayer/signature-aggregator/main/main.go:95 +0xd5b ```
feuGeneA
requested review from
iansuvak,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
reviewed
Sep 11, 2024
geoff-vball
approved these changes
Sep 12, 2024
iansuvak
approved these changes
Sep 12, 2024
geoff-vball
approved these changes
Sep 12, 2024
iansuvak
approved these changes
Sep 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Issues were encountered when trying to run the docker images built by the new release flow. This fixes the problems and polishes a few other things along the way.
How this was tested
by running the commands shown in the readme, and by pushing a
...-devrelease tag, which triggered the CI job here, which pushed the docker image to docker hub asavaplatform/signature-aggregator:v0.1.0-rc1-devhere, and then by running the docker image withHow is this documented
in the README changes