Add error HTTP status codes and fix error json marshal #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
writeJsonError
didn't actually correctly serialize errors since the anonymous struct it was marshalling didn't have exposed fields so it would marshall to an empty struct.Added status code to distinguish to the caller between user input errors and server side errors. Requests resulting in 5xx level errors can be retried and may succeed in the future while 4xx errors represent malformed or invalid input.
How this was tested
compiled the binary and manually tested against Fuji with common user supplied error cases. Got valid error reponses like:
How is this documented
Updated the docs