use local copy of install_avalanchego_release.sh #557
Conversation
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
Co-authored-by: bernard-avalabs <53795885+bernard-avalabs@users.noreply.github.com> Signed-off-by: Ian Suvak <ian.suvak@avalabs.org>
| @@ -0,0 +1,133 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
We once had this copied over from subnet-evm, but got rid of it for some reason. Are we not able to use the file directly from our submodule while setting some env vars? Would it possibly be worthwhile to make a PR to subnet-evm to make it usable if not? Just spitballing :)
There was a problem hiding this comment.
We use it like this in teleporter. I think scripts like this are reasonable to have copy pastad in individual repos IMO and we do it already with other scripts. Happy to be overridden though.
There was a problem hiding this comment.
Oh, lol forgot which repo I was in. Can we use the one from the teleporter submodule? I don't mind copying code if its the best/easiest option, just wondering if we can piggyback somewhere here
There was a problem hiding this comment.
each of them uses their own versions.sh we certainly can but then we end up with the same problem of coupling repos tighter than they need to be
There was a problem hiding this comment.
Yeah, that's fair, you've convinced me 😅
Why this should be merged
Allows for easier custom avalanchego vs subnet-evm versions assuming they are compatible with each other
How this works
Updates both the github e2e as well as
./scripts/e2e_test.shrunner to use avalanchego version from./scripts/versions.shinstead of using the version fromsubnet-evmrepo.How this was tested
Existing tests should pass.
How is this documented
Need to update README.md for the simplified flow