allow private peers param #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
cam-schultz
reviewed
Dec 6, 2024
go.mod
Outdated
| @@ -4,7 +4,7 @@ go 1.22.10 | |||
|
|
|||
| require ( | |||
| github.com/alexliesenfeld/health v0.8.0 | |||
| github.com/ava-labs/avalanchego v1.12.0-initial-poc.9.0.20241122192639-7c3ad181c928 | |||
| github.com/ava-labs/avalanchego v1.12.1-0.20241203223023-13e07a1b3a1e | |||
There was a problem hiding this comment.
Let's hold off on merging until #580 is merged to master.
There was a problem hiding this comment.
ava-labs/avalanchego#3573 has been merged
peers/app_request_network.go
Outdated
| @@ -81,6 +81,7 @@ func NewNetwork( | |||
| trackedSubnets set.Set[ids.ID], | |||
| manuallyTrackedPeers []info.Peer, | |||
| cfg Config, | |||
| allowPrivateIPs bool, | |||
There was a problem hiding this comment.
We can add a GetAllowPrivateIPs method to the peers.Config interface since it's present in both relayer and signature aggregator configs. That way we don't have to pass in this param.
Merged
iansuvak
approved these changes
Dec 10, 2024
cam-schultz
approved these changes
Dec 10, 2024
cam-schultz
approved these changes
Dec 10, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds a param to allow private peers to the app request network, also adding config fields to relayer and aggregator
Depends on ava-labs/avalanchego#3573
How this works
How this was tested
CLI etna flows for fuji and local
How is this documented