Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(ci): merge go and lint workflows and jobs together #144

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

qdm12
Copy link

@qdm12 qdm12 commented Feb 17, 2025

  • Less configuration code and one less file
  • Fail fast oriented: fast steps are at the beginning, slow steps are at the end of each job
  • 2 jobs left: libevm and tooling (for ./libevm/tooling)
  • A tiny bit slower overall, taking ~7m30 versus 6m45 due to less parallelism (worth it for simpler configs/step-by-step imo)

⚠️ this requires to remove the lint job from required jobs

@qdm12
Copy link
Author

qdm12 commented Feb 17, 2025

Why do we run libevm delta on every push/PR actually? Shouldn't we run it exclusively on releases for example?

- run: go mod tidy
- run: go generate ./...
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this was added, in case we add //go:generate commands in code in the future.


- name: git diff
run: git diff --exit-code
scandir: "./libevm"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be

Suggested change
scandir: "./libevm"
scandir: "./libevm/tooling"

?

@qdm12 qdm12 force-pushed the qdm12/ci/merge-jobs branch 3 times, most recently from 684412d to 9669aac Compare February 17, 2025 12:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant