-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(ci): merge go and lint workflows and jobs together #144
base: main
Are you sure you want to change the base?
Conversation
Why do we run |
- run: go mod tidy | ||
- run: go generate ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this was added, in case we add //go:generate
commands in code in the future.
|
||
- name: git diff | ||
run: git diff --exit-code | ||
scandir: "./libevm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
scandir: "./libevm" | |
scandir: "./libevm/tooling" |
?
- Set up Go -> actions/setup-go - git diff -> `git diff --exit-code` - Run ShellCheck -> `ludeeus/action-shellcheck@`
684412d
to
9669aac
Compare
libevm
andtooling
(for ./libevm/tooling)lint
job from required jobs