Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: fix NO_RACE + CI re-run on timeouts or fails of known flakes #1304

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

darioush
Copy link
Collaborator

@darioush darioush commented Aug 22, 2024

Too much shell quoting makes it not work when you run it with NO_RACE=1

For the other PR that got merged with its changes, this is an example showing it works:
https://github.com/ava-labs/subnet-evm/actions/runs/10533951904/job/29190820267?pr=1304

@darioush darioush requested a review from ceyonur as a code owner August 22, 2024 23:00
@darioush darioush changed the title fix script fix build_test.sh with NO_RACE Aug 22, 2024
ARR4N
ARR4N previously approved these changes Aug 23, 2024
ceyonur
ceyonur previously approved these changes Aug 23, 2024
* suggested ci improvement: re-run tests if failures are flakes

* remove flake indicators

* bash

* add more flakes

* fix bash
@darioush darioush dismissed stale reviews from ceyonur and ARR4N via 3fa1750 August 23, 2024 15:03
@darioush darioush enabled auto-merge (squash) August 23, 2024 15:06
@darioush darioush disabled auto-merge August 23, 2024 17:29
@darioush
Copy link
Collaborator Author

Actually I want to fix the panic/timeout case as well before merging this.

@darioush darioush marked this pull request as draft August 23, 2024 17:30
@darioush darioush marked this pull request as ready for review August 24, 2024 01:19
@darioush darioush changed the title fix build_test.sh with NO_RACE ci: fix NO_RACE + CI re-run on timeouts or fails of known flakes Aug 24, 2024
@darioush darioush merged commit 3ede00b into master Aug 26, 2024
13 checks passed
@darioush darioush deleted the fix-norace branch August 26, 2024 15:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants