Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set http body limit conf #1327

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Aug 30, 2024

Why this should be merged

Adds http-body-limit config for RPC

Fixes: #1321

How this works

Adds a new json config and sets for created RPC servers

How this was tested

no test in upstream code

How is this documented

it will be documented as soon as I figure out the new docs repo

@ceyonur ceyonur requested review from darioush and a team as code owners August 30, 2024 09:11
@ceyonur ceyonur changed the base branch from master to geth-v1.13.14-sq August 30, 2024 09:11
@ceyonur ceyonur self-assigned this Aug 30, 2024
Copy link
Collaborator

@darioush darioush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we add options for SetBatchLimits (itemLimit, maxResponseSize) as well?

@ceyonur ceyonur linked an issue Sep 2, 2024 that may be closed by this pull request
@ceyonur
Copy link
Collaborator Author

ceyonur commented Sep 2, 2024

lgtm, should we add options for SetBatchLimits (itemLimit, maxResponseSize) as well?

ideally yes. creating issues.

@ceyonur ceyonur merged commit a87d4f8 into geth-v1.13.14-sq Sep 2, 2024
11 checks passed
@ceyonur ceyonur deleted the set-http-body-limit-conf branch September 2, 2024 09:13
ceyonur added a commit that referenced this pull request Sep 2, 2024
* all changes from v.13.2-x branch

* squash initial changes

* remove unneeded files

* fix lint

* gas estimation fix

* accounts/keystore: fix test with sleep

* rpc fixes

* try with a smaller limit

* logging

* change the trim fn

* remove main_test from rpc

* txpool: remove unused "PendingFrom"

* set local-txs-enabled in load tests

* ready to format

* format: remove upstream go-ethereum

* format: rename packages as fork

* Revert "format: remove avalanche header"

This reverts commit 09d505bd5e906ac186643061437e665b116b5bf6.

* fix logging

* deadcode linting

* more linting

* fix mock

* fix unused

* expecteds

* passing UTs

* add comment

* unused

* resolve some open issues

* undo script change

* test resillience

* fix compile

* wip

* test is fixed

* fix expecteds

* nits

* fix merge

* remove todos

* try

* try

* try

* docker stuff

* fix

* does this work

* fix

* hardcode for now

* fix

* hardcode for now

* remove TODO comments

* fix

* make txindexer more similar to upstream

* peer/network: move ctx check

* enforce tips in miner

* align nits with arr4n

* remove use of deprecated type core.GenesisAccount

* Revert "peer/network: move ctx check"

This reverts commit 147da5f.

* fix ctx check

* fix ctx again

* undo vm_test changes

* reduce diffs with ARR4N's branch

* update for enforcing gasTip

* unbuffer chan

* update to use commit(true)

* use TestOnlyAllowDuplicateBlocks

* Revert "update to use commit(true)"

This reverts commit 71d949e.

* overflow in state_transition err

* add http body limit flag (#1327)

* Tail lock revisited (#1328)

* avoid modifying the pointer

* improve readability

* prevent race in tail reading

* improve repairTxIndexTail readability

* use shared func

---------

Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider adding a flag for SetHTTPBodyLimit
2 participants