Use startimestamp #1386
Merged
Use startimestamp #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This pull request introduces several changes to the
plugin/evmpackage, primarily focusing on adding support for retrieving current validators and modifying the structure of theCurrentValidatortype. The key changes are grouped into two themes: adding functionality and modifying data structures.How this works
Adding Functionality:
GetCurrentValidatorsmethod to theClientinterface and its implementation in theclientstruct inplugin/evm/client.go. This method allows fetching the current validators. [1] [2]Modifying Data Structures:
CurrentValidatorstruct inplugin/evm/service.goto replaceStartTimewithStartTimestampas auint64. This change reflects a shift from usingtime.Timeto a simpler timestamp format. [1] [2]GetCurrentValidatorsRequeststruct fromplugin/evm/service.goas it was not being used.How this was tested
locally
Need to be documented?
yes along with other changes
Need to update RELEASES.md?
related changes are not captured yet