rename sov to l1validator #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
previously approved these changes
Nov 14, 2024
ceyonur
added
the
DO NOT MERGE
ceyonur
removed
the
DO NOT MERGE
michaelkaplan13
approved these changes
Nov 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We will rename SoV to L1 Validator with https://github.com/ava-labs/avalanchego/pull/3546/files. This PR reflects that change in Subnet-EVM.
How this works
Field renaming:
plugin/evm/service.go: RenamedIsSoVtoIsL1ValidatorinCurrentValidatorstruct andGetCurrentValidatorsfunction. [1] [2]plugin/evm/validators/interfaces/interface.go: RenamedIsSoVtoIsL1ValidatorinValidatorstruct.plugin/evm/validators/state.go: RenamedIsSoVtoIsL1ValidatorinvalidatorDatastruct and related functions. [1] [2] [3] [4]plugin/evm/validators/state_test.go: Updated tests to reflect the renaming ofIsSoVtoIsL1Validator. [1] [2] [3] [4] [5] [6] [7] [8]plugin/evm/vm.go: RenamedIsSoVtoIsL1ValidatorinloadValidatorsfunction.plugin/evm/vm_validators_state_test.go: Updated tests to reflect the renaming ofIsSoVtoIsL1Validator. [1] [2]warp/verifier_backend_test.go: RenamedIsSoVtoIsL1ValidatorinTestUptimeSignaturesfunction.How this was tested
Locally & UTs should cover
Need to be documented?
No
Need to update RELEASES.md?
No