Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

mark flaky: TestTimedUnlock #1411

Merged
merged 1 commit into from
Dec 18, 2024
Merged

mark flaky: TestTimedUnlock #1411

merged 1 commit into from
Dec 18, 2024

Conversation

darioush
Copy link
Collaborator

new test flake observed (in keystore, not very surprising)

@darioush darioush marked this pull request as ready for review December 17, 2024 22:52
@darioush darioush requested review from ceyonur and a team as code owners December 17, 2024 22:52
@qdm12
Copy link
Collaborator

qdm12 commented Dec 18, 2024

Would it be complicated to fix the test TestTimedUnlock in accounts/keystore? Asking out of curiosity 🤔

@darioush
Copy link
Collaborator Author

@qdm12 It's an upstream test, feel free to dig into it. IMO upstream flakes are more of an annoyance than a priority to address.

@darioush darioush merged commit 665486f into master Dec 18, 2024
14 checks passed
@darioush darioush deleted the known-flake-TestTimedUnlock branch December 18, 2024 14:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@qdm12 qdm12 qdm12 approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darioush @qdm12