Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace logs by metrics on Kate #24

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

MiguelDD1
Copy link
Contributor

It replaces logs by metrics which will be pushed into Prometheus in the node.

@MiguelDD1 MiguelDD1 requested review from a team February 24, 2023 11:34
@MiguelDD1 MiguelDD1 self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 96.34% and project coverage change: -4.32 ⚠️

Comparison is base (4c32cbe) 58.89% compared to head (7c4e329) 54.57%.

❗ Current head 7c4e329 differs from pull request most recent head 6427c72. Consider uploading reports for the commit 6427c72 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   58.89%   54.57%   -4.32%     
==========================================
  Files          41       43       +2     
  Lines        5561     6133     +572     
==========================================
+ Hits         3275     3347      +72     
- Misses       2286     2786     +500     
Impacted Files Coverage Δ
kate/src/lib.rs 70.17% <ø> (ø)
primitives/avail/src/header/mod.rs 60.00% <ø> (+2.20%) ⬆️
primitives/avail/src/traits.rs 4.34% <ø> (-0.60%) ⬇️
kate/src/metrics.rs 83.33% <83.33%> (ø)
...imitives/avail/src/asdr/app_unchecked_extrinsic.rs 71.71% <93.33%> (+2.54%) ⬆️
kate/src/com.rs 96.37% <100.00%> (+1.58%) ⬆️
kate/recovery/src/index.rs 46.34% <0.00%> (-10.65%) ⬇️
primitives/nomad/signature/src/signature.rs 48.45% <0.00%> (-6.27%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MiguelDD1 MiguelDD1 merged commit 6b1fd23 into main Mar 1, 2023
@MiguelDD1 MiguelDD1 deleted the AV-131-add-block-production-metrics-to-prometheus branch March 1, 2023 11:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants