add support for utility pallet in data root generation #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabal-banerjee
approved these changes
Jul 5, 2023
0xSasaPrsic
reviewed
Jul 6, 2023
0xSasaPrsic
approved these changes
Jul 6, 2023
fmiguelgarcia
approved these changes
Jul 14, 2023
Leouarz
requested review from
0xSasaPrsic,
fmiguelgarcia,
prabal-banerjee and
markopoloparadox
| { | ||
| /// utility constructor. Used only in client/factory code. | ||
| pub fn from(app_id: AppId) -> Self { Self(app_id, sp_std::marker::PhantomData) } | ||
|
|
||
| /* pub fn validate_batch_call(&self, call: &<T as pallet_utility::Config>::RuntimeCall) {} */ |
There was a problem hiding this comment.
Remove commented code
prabal-banerjee
approved these changes
Jul 21, 2023
fmiguelgarcia
requested changes
Jul 24, 2023
kroos47
approved these changes
Jul 26, 2023
…ption Replace `Option<Vec<Vec<..>>` by `Vec<Vec<..>>`
fmiguelgarcia
approved these changes
Jul 27, 2023
markopoloparadox
approved these changes
Jul 27, 2023
markopoloparadox
approved these changes
Jul 27, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/availproject/engineering/issues/99