Skip to content

Make Jakarta Inject required in module-info #676

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Aug 27, 2024

I ran into some jlink trouble.

This changes jakarta.inject from being static/optional to being a required module dependency in module-info.

I ran into some jlink trouble
@SentryMan SentryMan added the bug Something isn't working label Aug 27, 2024
@SentryMan SentryMan self-assigned this Aug 27, 2024
@SentryMan SentryMan enabled auto-merge August 27, 2024 01:39
@SentryMan SentryMan requested a review from rbygrave August 27, 2024 01:39
@SentryMan SentryMan added this to the 10.4 milestone Aug 27, 2024
@rbygrave rbygrave changed the title Make Jakarta Inject required Make Jakarta Inject required in module-info Aug 27, 2024
@rbygrave rbygrave disabled auto-merge August 27, 2024 06:00
@rbygrave rbygrave merged commit 6be8489 into master Aug 27, 2024
13 checks passed
@rbygrave rbygrave deleted the SentryMan-patch-1 branch August 27, 2024 06:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants