Add support for building against Valhalla EA #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
commented
Aug 28, 2024
inject-generator/src/test/java/io/avaje/inject/generator/InjectProcessorTest.java
Show resolved
Hide resolved
SentryMan
approved these changes
Aug 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using many
valueclasses here in avaje-inject but I think this might be a decent approach/pattern if we want to build and test using Valhalla value classes. If this is a good idea/approach then could look at doing something similar with avaje-jsonb?The guts is that there is a
/*value*/ classplaceholder that can regex replaced tovalue class(in a similar manor to the jakarta to javax approach).