Skip to content

Merge Detected Services into META-INF #733

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 14, 2024

  • Now will add all detected modules/plugins to META-INF/services
  • add an option to disable just in case
  • now maven/gradle plugin will output plugin information in a csv format

resolves #731

relies on prisms 1.35

@SentryMan SentryMan added the enhancement New feature or request label Nov 14, 2024
@SentryMan SentryMan requested a review from rbygrave November 14, 2024 01:49
@SentryMan SentryMan self-assigned this Nov 14, 2024
@rbygrave
Copy link
Contributor

add all detected modules/plugins to META-INF/services

I'm looking to understand the exact use case for this. I believe this is only applicable when the maven shade plugin is used (or similar) to merge multiple modules into a single jar right?

As I see it, there will likely be other META-INF/services that also need to be handled/merged by the maven shade plugin, so this doesn't address that issue.

So what is the exact use case for this?

@rbygrave
Copy link
Contributor

Ah, apologies, conversation is on the issue ... moving over there.

@SentryMan SentryMan enabled auto-merge (squash) November 14, 2024 19:58
@SentryMan SentryMan added this to the 10.6 milestone Nov 18, 2024
@SentryMan SentryMan merged commit c42eb5c into avaje:master Nov 19, 2024
7 checks passed
@SentryMan SentryMan deleted the mergeServices branch November 20, 2024 03:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all detected modules/plugins to generated META-INF/services/io.avaje.inject.spi.InjectExtension entries
2 participants