Skip to content

Write value classes when running on Valhalla #283

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2024
Merged

Write value classes when running on Valhalla #283

merged 3 commits into from
Aug 5, 2024

Conversation

SentryMan
Copy link
Collaborator

  • Will write value classes when on Valhalla
  • modify @Json.Value generation for compatibility (apparently you can't use return in a value class constructor)

resolves #281

@SentryMan SentryMan added the enhancement New feature or request label Aug 3, 2024
@SentryMan SentryMan requested a review from rbygrave August 3, 2024 19:09
@SentryMan SentryMan self-assigned this Aug 3, 2024
@SentryMan SentryMan added this to the 2.1 milestone Aug 3, 2024
@rbygrave rbygrave merged commit c129c6a into avaje:main Aug 5, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Generate value classes when on valhalla
2 participants
@SentryMan @rbygrave