Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Officially disable snapshots in hooks (remove experiment) #2534

Closed
novemberborn opened this issue Jul 4, 2020 · 0 comments
Closed

Officially disable snapshots in hooks (remove experiment) #2534

novemberborn opened this issue Jul 4, 2020 · 0 comments
Labels
breaking requires a SemVer major release
Milestone
4.0

Comments

@novemberborn
Copy link
Member

For the next major AVA release, remove the experiment introduced in d01db61 so that t.snapshot() no longer works in hooks.
@novemberborn novemberborn added the breaking requires a SemVer major release label Jul 4, 2020
@novemberborn novemberborn added this to the 4.0 milestone Jul 4, 2020
@novemberborn novemberborn changed the title Officially disable snapshots in hooks Officially disable snapshots in hooks (remove experiment) Jul 4, 2020
novemberborn added a commit that referenced this issue Feb 7, 2021
@novemberborn
snapshot() assertion no longer works in hooks
6d1adfc 
Fixes #2534.
bunysae pushed a commit to bunysae/ava that referenced this issue Feb 14, 2021
@novemberborn @bunysae
snapshot() assertion no longer works in hooks
09be3fd 
Fixes avajs#2534.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
breaking requires a SemVer major release
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@novemberborn