-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
document that ava assertions don't throw #2624
Comments
I thought it was referenced, but I can't immediately spot it in the obvious places. This hints at it:
(From https://github.com/avajs/ava/blob/master/docs/03-assertions.md). That might be the best spot to add a clarification? |
I'd scatter reinforcement of the idea at several places, since reference documents are often not read linearly, and "assert doesn't throw" is pretty unusual; in almost every other programming context, assert does throw. I can make a PR in a day or so. |
@f5lee fantastic, thank you. |
For reference, see also #1485 |
Adding text in assertion planning in order to inform about ava assertion not stopping even when they fail linked to issue (document that ava assertions don't throw avajs#2624)
Fixed by #3246. |
I didn't realize until recently that ava assertions don't stop the test when they fail.
I think this could be documented better, and I'm willing to do so if that's useful
The text was updated successfully, but these errors were encountered: