Skip to content

Conversation

novemberborn
Copy link
Member

@novemberborn novemberborn commented Jun 2, 2022

  • Only test against TypeScript 4.7
  • Move type definitions to entrypoints/. Only TS 4.7 will resolve them now, but it's cleaner.
  • Remove direct invocation of tsd, rely on tsc --noEmit instead
  • Test with .cts files, containing ESM import syntax

@novemberborn novemberborn added the breaking requires a SemVer major release label Jun 2, 2022
@novemberborn novemberborn force-pushed the require-ts4.7 branch 2 times, most recently from 68266d9 to 7986182 Compare June 5, 2022 17:38
@novemberborn
Copy link
Member Author

I'd like to test CJS import syntax as well but I already cannot remember how that's meant to be configured and used.

Somehow `npx tsc` was pointing at an older version. Possibly the binstubs are corrupted in CI… somehow.
@novemberborn novemberborn marked this pull request as ready for review July 10, 2022 16:28
@novemberborn novemberborn merged commit 02f4e27 into main Jul 10, 2022
@novemberborn novemberborn deleted the require-ts4.7 branch July 10, 2022 16:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking requires a SemVer major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant