Address error in tap reporter when originalError is undefined

[evmiguel]

This is a follow up from the discussion in #3322. The tap reporter was failing when ava timed out because of

ava/lib/reporters/tap.js

Line 27 in 01ec280

originalError.name = name; // Restore the original name.

being undefined.

The suggestion was to use optional chaining on the left side of the assignment, but I ran into the tests failing, so I wrapped the assignment in an if condition.

[novemberborn]

The suggestion was to use optional chaining on the left side of the assignment, but I ran into the tests failing, so I wrapped the assignment in an if condition.

Yes that's my bad, you can't use optional chaining on the left hand side in an assignment.

[novemberborn]

@evmiguel looking at the rest of the function, the originalError.stack assignment would also fail.

Looking at how dumpError is called, I don't see how it would be called with an undefined value. Could you provide a reproduction of the error?

[novemberborn]

Closing due to inactivity. We'd be happy to pick this up again when you have the time to get back to this.