Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Node to v 16 since v12 is deprecated #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardsimko
Copy link

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: avakar/create-deployment

`Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: avakar/create-deployment`
@nielsbox
Copy link

@avakar Any reason why this is not merged yet?

Copy link

@wasuint wasuint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good to me. Let's merge this PR asap.

@ahsan-rao
Copy link

@avakar Is there anything preventing this PR from being merged? Let me know if I can help in any way. Thanks!

@@ -56,5 +56,5 @@ outputs:
description: The API url of the deployment statuses.

runs:
using: 'node12'
using: 'node16'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be Node 20 now to avoid the deprecation warnings: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been 1.5 years, I sadly don't think this PR will get merged 😢

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants