Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Absence of error messages from external nREPL #112

Closed
vganshin opened this issue Jul 1, 2018 · 0 comments · May be fixed by #114
Closed

Absence of error messages from external nREPL #112

vganshin opened this issue Jul 1, 2018 · 0 comments · May be fixed by #114

Comments

@vganshin
Copy link
Contributor

vganshin commented Jul 1, 2018

Connect to a running nREPL. Eval and show result of some faulty code. You'll see:

undefined undefined
 at undefined:62:0

instead of an error message.
marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Jul 19, 2018
@marcomorain
Recover from errors more nicely.
9bccf10 
There are two changes here.

Firstly, detect when the call to get a stacktrace fails with `unknown-op` - this
indicates that the cider middleware to get stack traces is not loaded.

This lead to the second change: after I fixed the first issue (which is bug avli#112
I noticed that if you do not have the clojure stack trace middleware, you could
not see the reason for compilation errors. So rather than get a stack trace when
compilation fails, we can print the error message from the compilation operation.

This makes compilation errors take only 1 line on the output panel, which is much
nicer.

Fixes avli#112
@marcomorain marcomorain mentioned this issue Jul 19, 2018
Open
@vganshin vganshin closed this as completed Jul 6, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recover from errors more nicely. marcomorain/clojureVSCode
1 participant
@vganshin