Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SubGeometry casts Number face weights to uint (possible loss of data?) #505

Closed
iaddis opened this issue Apr 11, 2013 · 2 comments
Closed

Comments

@iaddis
Copy link

iaddis commented Apr 11, 2013

Please verify that this is not an issue. _faceWeights is a Vector. and is being cast to a uint. This happens in other methods in this class.

        private function updateVertexNormals() : void
        {
            var weight : uint;

            while (i < lenI) {
                weight = _useFaceWeights? _faceWeights[k++] : 1;
            }
@JohnBrookes
Copy link
Member

See line 238 subGeomBase
The faceweights are +ve and rounded up.
So no real data loss with them being set to uint later.

Maybe just set the _faceWeights vector to be uint and set _faceWeights[k++] = uint(w);
Or just close the issue?

JohnBrookes added a commit to JohnBrookes/away3d-core-fp11 that referenced this issue Apr 13, 2013
SubGeometry casts Number face weights to uint
@rob-bateman
Copy link
Member

merged in dev 81709b9

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants