Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

widget: Added widget_template argument to layoutbox #3208

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suharelli
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #3208 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3208   +/-   ##
=======================================
  Coverage   88.22%   88.23%           
=======================================
  Files         662      662           
  Lines       44962    44964    +2     
=======================================
+ Hits        39666    39672    +6     
+ Misses       5296     5292    -4     
Flag Coverage Δ
gcov 75.29% <ø> (+0.04%) ⬆️
luacov 91.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/awful/widget/layoutbox.lua 100.00% <100.00%> (ø)
dbus.c 41.44% <0.00%> (+1.20%) ⬆️

lib/awful/widget/layoutbox.lua Outdated Show resolved Hide resolved
Copy link
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh really, docsting is missing for widget_template

@suharelli suharelli requested a review from actionless November 6, 2020 14:31
Copy link
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants