Skip to content

test(DataStore): Update schemas for use 'sub' as default identity claim feature #1633

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

div5yesh
Copy link
Contributor

@div5yesh div5yesh commented Jan 21, 2022

Issue #, if available:

Description of changes:
The change in CLI tagged release @aws-amplify/cli@7.6.8-sub-identity-claim.1 will provision backends and codegen the default identity claim as sub, previously cognito:username.

This PR is running automated tests related to the usage of @auth with default owner field in the schema.

The code generated model files contains the explicit identityClaim key, which has been updated from cognito:username to sub (see model schema file changes in this PR).

  • Tests that were in place with regards to these schemas were tested.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@div5yesh div5yesh requested a review from a team January 21, 2022 18:58
@div5yesh div5yesh added cli Issues with the Amplify CLI, waiting to be transfered into amplify-cli. datastore DataStore category/plugins infrastructure CI/CD, test frameworks, backend resources, etc. labels Jan 21, 2022
gpanshu
gpanshu previously approved these changes Feb 15, 2022
sktimalsina
sktimalsina previously approved these changes Feb 15, 2022
Copy link
Member

@sktimalsina sktimalsina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase and test fixes.
Otherwise LGTM!

@div5yesh div5yesh requested review from a team as code owners June 22, 2022 00:31
@div5yesh div5yesh enabled auto-merge (squash) June 22, 2022 00:31
auto-merge was automatically disabled April 19, 2023 15:39

Merge queue setting changed

gpanshu and others added 2 commits August 24, 2023 09:27
…all onFailure (#2255)

Co-authored-by: Matt Creaser <mattwcc@amazon.com>
Co-authored-by: gpanshu <91897496+gpanshu@users.noreply.github.com>
@gpanshu gpanshu dismissed stale reviews from sktimalsina and themself via c37a5a4 August 24, 2023 15:19
@gpanshu gpanshu enabled auto-merge (squash) September 1, 2023 18:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cli Issues with the Amplify CLI, waiting to be transfered into amplify-cli. datastore DataStore category/plugins infrastructure CI/CD, test frameworks, backend resources, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants