Skip to content

fix(datastore): Add missing onError handlers #2844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2817

Description of changes:

  • Added RxLint lint checks. These checks highlight potential RxJava errors such as missing error handlers.
  • Resolved all RxLint errors

How did you test these changes?

  • Manual testing

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner June 10, 2024 18:20
vincetran
vincetran previously approved these changes Jun 10, 2024
@mattcreaser mattcreaser enabled auto-merge (squash) July 10, 2024 14:27
@mattcreaser
Copy link
Member Author

This PR is failing on some integration tests. I will try to investigate when I get time.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants