Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: 🤖 add support for ap-northeast-3 KIX #1741

Merged
merged 2 commits into from
Aug 1, 2023
Merged

chore: 🤖 add support for ap-northeast-3 KIX #1741

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6686bd
chore: 🤖 add support for ap-northeast-3 KIX
petercwk-aws Jul 29, 2023
d943414
chore: 🤖 remove kix region until added to CLI
petercwk-aws Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/amplify-category-api/src/provider-utils/supported-datasources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const supportedDataSources = {
'ap-southeast-2',
'ap-northeast-1',
'ap-northeast-2',
'ap-northeast-3',
'ca-central-1',
'eu-central-1',
'eu-north-1',
Expand Down
1 change: 1 addition & 0 deletions packages/amplify-e2e-core/src/configure/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const amplifyRegions = [
'eu-central-1',
'ap-northeast-1',
'ap-northeast-2',
'ap-northeast-3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change should be excluded until the CLI has released the region option in amplify configure. Otherwise it could cause the API e2e test failure. (I am testing with latest version 12.2.3 and do not find the new region).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in the last revision.

'ap-southeast-1',
'ap-southeast-2',
'ap-south-1',
Expand Down