Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove v10 and some v8 migration tests that use nodejs 14.x #13604

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Feb 20, 2024

Description of changes

This PR removes tests that use old version of CLI that tries to deploy Node 14.x lambdas.

The reason is that Lambda service no longer allows Node 14.x functions.

I.e.

ESC[KESC[91m    UserPoolClientLambda           AWS::Lambda::Function          CREATE_FAILED                  Tue Feb 20 2024 ESC[39m
ESC[?25h

🛑 ESC[31mThe following resources failed to deploy:ESC[39m

ESC[31mResource Name:ESC[39m UserPoolClientLambda (AWS::Lambda::Function)
ESC[31mEvent Type:ESC[39m create
ESC[31mReason:ESC[39m Resource handler returned message: "The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: a26c4f9a-2814-49e1-a3b9-add806b06281)" (RequestToken: b6e2c9f8-b6eb-0bb6-12d8-6457775c7c3e, HandlerErrorCode: InvalidRequest)


ESC[31mResource Name:ESC[39m LambdaFunction (AWS::Lambda::Function)
ESC[31mEvent Type:ESC[39m create
ESC[31mReason:ESC[39m Resource handler returned message: "The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: cb2cac38-f5c1-48dc-b252-cc21dfe86492)" (RequestToken: cfb395a8-bd19-4edf-bbc7-2498a62218e0, HandlerErrorC
ode: InvalidRequest)

Issue #, if available

Description of how you validated changes

E2E tests, PR check

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

edwardfoyle and others added 4 commits January 9, 2024 15:11
 - @aws-amplify/amplify-category-notifications@2.26.12
 - @aws-amplify/cli@12.10.1
 - @aws-amplify/cli-internal@12.10.1
 - @aws-amplify/amplify-provider-awscloudformation@8.10.2
 - @aws-amplify/amplify-util-mock@5.9.2
@sobolk sobolk changed the title chore: remove v10 migration tests that use nodejs 14.x chore: remove v10 and v8 migration tests that use nodejs 14.x Feb 20, 2024
@sobolk sobolk marked this pull request as ready for review February 20, 2024 23:40
@sobolk sobolk requested a review from a team as a code owner February 20, 2024 23:40
@sobolk sobolk changed the title chore: remove v10 and v8 migration tests that use nodejs 14.x chore: remove v10 and some v8 migration tests that use nodejs 14.x Feb 21, 2024
@sobolk sobolk merged commit 178a4fe into aws-amplify:dev Feb 21, 2024
6 checks passed
@sobolk sobolk deleted the remove-v10-migration-tests branch February 21, 2024 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants