-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
AWS Amplify Gen1 V6 is unable to resume file upload #14149
Comments
Hey @happypgh, thanks for creating this issue, we will review this internally and follow up. |
@happypgh, we can reproduce this on our side and will investigate this as a bug at this time. Thank you for opening this, and we'll follow up with any updates as we have them. |
@cwomack thanks! |
Hi @cwomack, it looks like the issue has already been fixed and approved. Would you be able to provide any ETA for the release? |
Hi @happypgh, The fix will be released in the next release. Although we normally don't provide ETAs, but it will be available soon. |
Got it. Thank you so much for fixing it quickly! 👍 |
Thank you thank you !!! You guys are awesome! |
@Samaritan1011001 I've just confirmed the issue has been resolved with 6.12.2 Much appreciated 🙏 |
That's right. As long as the options being set on each file upload are the same, in this case is empty, the options hash are the same. |
Before opening, please confirm:
JavaScript Framework
React
Amplify APIs
Storage
Amplify Version
v6
Amplify Categories
storage
Backend
None
Environment information
Describe the bug
I have just upgraded my AWS Amplify Gen1 V5 to V6 and noticed resumable upload does not seem to be able to continue uploading a file that was unexpectedly stopped before when I call uploadData for the exact same file again.
My understanding is the library keeps track of upload progress as __uploadInProgress dictionary in local storage.
Looking at the source code, it looks like getUploadsCacheKey() is the one that builds the dictionary key and it requires optionsHash to construct the key.
The problem is optionsHash calculated by calculateContentCRC32() is different every time I call uploadData for the same file.
This is what I call
and this is what's remaining in the local storage after attempting to upload and refresh the browser 3 times for the exact same file source and as you can see, the optionsHash part is different for every entry.
Expected behavior
The browser is able to resume unexpectedly stopped uploads
Reproduction steps
Code Snippet
Log output
aws-exports.js
No response
Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response
The text was updated successfully, but these errors were encountered: