fix(storage): omit unserializable properties when hash uploadDataOptions #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
fix-14149
branch
from
f1a7133 to
126e435
Compare
AllanZhengYP
force-pushed
the
fix-14149
branch
from
126e435 to
14a23f7
Compare
AllanZhengYP
requested review from
sktimalsina,
cshfang,
HuiSF,
pranavosu and
a team
as code owners
AllanZhengYP
force-pushed
the
fix-14149
branch
from
15be2b1 to
914d289
Compare
HuiSF
reviewed
Jan 22, 2025
packages/storage/src/providers/s3/apis/internal/uploadData/multipart/uploadHandlers.ts
Show resolved
Hide resolved
jjarvisp
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Is determining if something is serializable or not sufficient to resolve the underlying issue moving forward? It seems to me like the problem was created by something that was serializable and just shouldn't have been included in the calculation of the options hash.
… runtime types" This reverts commit 914d289.
ashika112
reviewed
Jan 22, 2025
| resumableUploadsCache?: KeyValueStorageInterface; | ||
| } = {}, | ||
| ): string => { | ||
| const unserializableOptionProperties: string[] = [ |
There was a problem hiding this comment.
lets leave a comment maybe to update this as needed
ashika112
approved these changes
Jan 22, 2025
jjarvisp
approved these changes
Jan 22, 2025
HuiSF
approved these changes
Jan 22, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
From #13931, we added a internally-injected option
resumableUploadsCachefor public uploadData API. However, the default value of this optionKeyValueStoragehas a reference to theLocalStorageinstance.This causes that the hash value of uploadData options keeps changing, as the
LocalStoragevalue keep changing. This fix adds a list of options that should NOT be hashed when calculating the options hash. Any new options will be added options hash by default.Issue #, if available
#14149
Description of how you validated changes
Unit test; Manual integ test
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.