fix(storage): nextToken is not surfaced when list result contain only CommonPrefix #13933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
haverchuck,
cshfang,
jimblanc and
a team
as code owners
jimblanc
approved these changes
Oct 17, 2024
ashika112
approved these changes
Oct 17, 2024
|
Thanks Hui Nice Catch ! |
HuiSF
force-pushed
the
hui/fix/storage/no-next-token
branch
from
680b1fc to
6de4423
Compare
AllanZhengYP
approved these changes
Oct 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It is a legit case that
ListObjectV2returns a result that contains onlyCommonPrefix[]and without aContent, andNextContinuationTokencan be returned as well.The current implementation omits
nextTokenfor this case, and makes listing next page impossible.Fix: surface the
nextTokenIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.