New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(auth): add support for Email MFA #13945

Merged

jjarvisp merged 16 commits into main from feat/email-mfa

Oct 31, 2024

Member

jjarvisp commented Oct 22, 2024 •

edited

Loading

Description of changes

The purpose of this pull request is to enable support for multi-factor authentication with email.

Issue #, if available

Description of how you validated changes

manual tests
unit tests
integration tests

Checklist

PR description included
yarn test passes
Unit Tests are changed or added
Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jjarvisp and others added 9 commits

September 6, 2024 15:38


          [Email MFA] Updating fetchMFAPreference and updateMFAPreference (#13720)

164e9cc

* add EMAIL MFA option in fetchMFAPreference

* add EMAIL MFA option in updateMFAPreference

* update fetchMFAPreference tests

* update updateMFAPreference tests

* update bundle size

* remove redundant assertions


          [Email MFA] Add support for EMAIL_OTP during # flows (#13745)

4b2c458

* Confirm # With Email OTP

* Confirm # Tests With Email OTP

* Update packages/auth/src/types/models.ts

Co-authored-by: israx <70438514+israx@users.noreply.github.com>

* Fix Errant Pascal Casing

---------

Co-authored-by: israx <70438514+israx@users.noreply.github.com>


          feat(auth): [EMAIL MFA] # / Confirm # With MFA_SETUP (#13760

c1c7a5e

)

* # / Confirm # With MFA_SETUP

* # State Management Tests

* Confirm # Happy Path Tests

* Fix State Management Tests

* Apply Feedback

* loose email matching

* Remove Unnecessary Export

* Update SignInHelpers For Getting Allowed MFA Setup Types

* Add Error Case Unit Tests


          feat(auth): [EMAIL MFA] enable integ tests with backend configuration…

6da0652

… swapping (#13794)

* chore: enable mfa integ tests

* chore: add mfa-setup test def


          Merge branch 'main' into refactor/email-mfa-service-client-factory

07ad2ef


          Merge branch 'main' into feat/email-mfa

cb2de38


          Merge branch 'main' into feat/email-mfa

67fe90e


          Merge branch 'main' into feat/email-mfa

d9dcee0


          chore: temporarily enable push integ tests

93bea39

jjarvisp requested review from haverchuck, cshfang, HuiSF and a team as code owners

October 22, 2024 00:53

github-advanced-security bot found potential problems

View reviewed changes

packages/auth/src/providers/cognito/utils/signInHelpers.ts Fixed Show fixed Hide fixed


          chore: disable push integ tests

2fa41ae

jjarvisp force-pushed the feat/email-mfa branch from c3f4855 to 2fa41ae Compare

October 22, 2024 16:09

HuiSF reviewed

View reviewed changes

packages/auth/src/providers/cognito/utils/signInHelpers.ts Outdated Show resolved Hide resolved

packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts Outdated Show resolved Hide resolved

packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts Outdated Show resolved Hide resolved


          chore: address test strategy feedback

github-advanced-security bot found potential problems

View reviewed changes

packages/auth/src/providers/cognito/utils/signInHelpers.ts Fixed Show fixed Hide fixed

jjarvisp force-pushed the feat/email-mfa branch from 2975f90 to 3493336 Compare

October 24, 2024 20:53


          chore: use trimmed challenge response

3258ee9

ashika112 reviewed

View reviewed changes

packages/auth/__tests__/providers/cognito/signInErrorCases.test.ts Outdated Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Outdated Show resolved Hide resolved

ashika112 reviewed

View reviewed changes

packages/auth/src/providers/cognito/utils/signInHelpers.ts Show resolved Hide resolved

ashika112 previously approved these changes

View reviewed changes


          chore: improved naming

026d8de

jjarvisp dismissed ashika112’s stale review via

026d8de

October 24, 2024 22:10

jjarvisp requested a review from ashika112

October 24, 2024 22:35

ashika112 previously approved these changes

View reviewed changes

Tahir500 approved these changes

View reviewed changes

HuiSF previously approved these changes

View reviewed changes


          Merge branch 'main' into feat/email-mfa

f3c3c62

jjarvisp requested a review from pranavosu as a code owner

October 31, 2024 00:51


          chore: update bundle size tests

d2d4470

jjarvisp dismissed stale reviews from ashika112 and HuiSF via

d2d4470

October 31, 2024 01:07

jjarvisp requested review from HuiSF and ashika112

October 31, 2024 01:25

cshfang reviewed

View reviewed changes

packages/auth/__tests__/providers/cognito/confirmSignInErrorCases.test.ts Show resolved Hide resolved

packages/auth/__tests__/providers/cognito/updateMFAPreference.test.ts Show resolved Hide resolved

packages/auth/__tests__/providers/cognito/updateMFAPreference.test.ts Show resolved Hide resolved

packages/auth/__tests__/providers/cognito/updateMFAPreference.test.ts Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Outdated Show resolved Hide resolved

packages/auth/src/common/AuthErrorStrings.ts Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Show resolved Hide resolved

packages/auth/src/providers/cognito/utils/signInHelpers.ts Show resolved Hide resolved

cshfang previously approved these changes

View reviewed changes

ashika112 previously approved these changes

View reviewed changes


          chore: remove trimmed challenge response

8f46f05

jjarvisp dismissed stale reviews from ashika112 and cshfang via

8f46f05

October 31, 2024 17:34

jjarvisp requested review from cshfang and ashika112

October 31, 2024 17:52

ashika112 approved these changes

View reviewed changes

cshfang approved these changes

View reviewed changes

jjarvisp merged commit 42db720 into main

30 checks passed

jjarvisp deleted the feat/email-mfa branch

October 31, 2024 18:33

jjarvisp mentioned this pull request

refactor(auth): email mfa optimizations #13981

Closed

6 tasks

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

ashika112 ashika112 approved these changes

cshfang cshfang approved these changes

Tahir500 Tahir500 approved these changes

haverchuck Awaiting requested review from haverchuck

pranavosu Awaiting requested review from pranavosu

HuiSF Awaiting requested review from HuiSF HuiSF is a code owner

Labels

None yet